-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define CloudWatch Alarm Payload structure #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 74.06% 74.06%
=======================================
Files 18 18
Lines 833 833
=======================================
Hits 617 617
Misses 152 152
Partials 64 64 Continue to review full report at Codecov.
|
bmoffatt
requested changes
Jun 9, 2020
bmoffatt
reviewed
Jun 9, 2020
events/testdata/cloudwatch-alarm-sns-payload-single-metric.json
Outdated
Show resolved
Hide resolved
bmoffatt
approved these changes
Jul 21, 2020
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Tries to solve an issue similar to #51 for CloudWatch Alarm Payload in a SNSEvent. If this this merged, can do another PR to resolve #51
Description of changes
TL;DR
Added struct for CloudWatch Alarm payload.
Details
Structs Details
CloudWatchAlarmSnsPayload
struct refers to first level in the JSON containing information.CloudWatchAlarmTrigger
struct refers to the trigger information.CloudWatchMetricDataQuery
struct refers to the list of Metrics inside Trigger.CloudWatchMetricStat
struct refers to the MetricStat key inside the Metric Data Query.CloudWatchMetric
struct refers to the Metric information inside MetricStat.CloudWatchDimension
struct refers to Dimensions of the metric inside CloudWatchMetric.Why so many structs?
CloudWatchAlarmSnsPayload
are already defined in the CloudWatch module in the AWS GO SDK.json
definitions and hence to be in sync with how SNS related structs are defined, these have to defined again.CloudWatchAlarmSnsPaylaod
but for better readability nested structs are defined separately.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.